-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export shp file #1111
base: master
Are you sure you want to change the base?
fix: export shp file #1111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stempler thank you |
if (schemaFbMap.get(localPart) != null | ||
&& schemaFbMap.get(localPart).get(geometryType) != null) { | ||
schemaFbMap.get(localPart).get(geometryType).add(value); | ||
if (schemaFbMap.get(localPart) != null && value != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emanuelaepure10 as discussed I think a null check for value
here might have impact on attributes not present in the export. Also, this might not prevent the IndexOutOfBounds exception if all the additional values are not null. I believe we should analyse the data and try to pass in all the attributes during schema creation in step 2.
This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
Fix the export of a shape file. ING-4189
10e515e
to
295b875
Compare
Fix the export of a shape file which was failing with the error “can handle 7 attributes only, index is 7.“
ING-4189