Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export shp file #1111

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emanuelaepure10
Copy link
Contributor

Fix the export of a shape file which was failing with the error “can handle 7 attributes only, index is 7.“

ING-4189

Copy link
Member

@stempler stempler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emanuelaepure10
Copy link
Contributor Author

@stempler thank you
you were faster them me asking for it :-D

@emanuelaepure10 emanuelaepure10 marked this pull request as draft February 21, 2024 15:04
if (schemaFbMap.get(localPart) != null
&& schemaFbMap.get(localPart).get(geometryType) != null) {
schemaFbMap.get(localPart).get(geometryType).add(value);
if (schemaFbMap.get(localPart) != null && value != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emanuelaepure10 as discussed I think a null check for value here might have impact on attributes not present in the export. Also, this might not prevent the IndexOutOfBounds exception if all the additional values are not null. I believe we should analyse the data and try to pass in all the attributes during schema creation in step 2.

Copy link

github-actions bot commented May 6, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 6, 2024
@emanuelaepure10 emanuelaepure10 added confirmed Issue has been confirmed and removed stale labels May 6, 2024
Fix the export of a shape file.

ING-4189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue has been confirmed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants