Update Elm Webpack Loader to v4 #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackfranklin Thanks for the PR! It looks like hot reloading does not work with the latest loader and unfortunately #80 is not fixing it for Create Elm App. I will give it a shot at fixing the issue during the next week #84 |
halfzebra
force-pushed
the
master
branch
2 times, most recently
from
3328da7
to
b46321d
Compare
|
@jackfranklin Hi Jack! Thanks for this PR! 👍 Unfortunately, during the time of this PR the loaders weren't stable enough, so we couldn't use them with Create Elm App. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that this shouldn't be merged yet because of elm-community/elm-webpack-loader#80. That PR to fix hot loading has been merged but is not released yet - but maybe we can just leave this PR open and I'll update it when elm-webpack-loader is released? Unless you feel comfortable depending on a git commit in a
package.jsonwhich I'm not sure about.I also think this should make Elm Webpack report warnings correctly so once this is done I can take a stab at #15 again.