Allow for larger and variable length salts in the check function - fixes #13 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #13 by allowing for variable length salts, it also allows for longer salts by separating out the default salt length (which remains at 16) ,used for encrypting new passwords in the module, from the maximum salt length (set to 64 - same as the max DK size for sha512, as larger salts would most likely be meaningless) that is used during verification against existing records.
This is a cleaned up version of a patch I've been using for the last year or so in an LDAP directory populated by data (including password hashes in pbkdf2) from a Django database, and it has been working well so far.