Improve handling of deprecated attributes; allow for replacement via WP-CLI #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things here:
customTaxonomy
is a string or an array.customTaxonomy
andtaxonomies
attributes added.customTaxonomy
attribute itself has been deprecated for a while.So - I think this PR starts setting us up to remove these entirely—primarily because we're really the only ones using this plugin. I've added temporary code to upgrade these attributes in place both in the editor and on the front-end. I've also added a WP-CLI command that we can use to fix the content all at once.
Ideally, after we run
wp cab fix-block-attributes
on sites that need it (after checkingwp cab audit-blocks
), then we can remove all of the fallbacks and rely only on thetaxonomies
attribute.At the same time I noticed that
customPostType
is/was being stored likedocument,document
, etc... and causing the selection box to default to "Posts" even when document was selected. I don't think we actually rely on that structure, so I've updated that in the WP-CLI command as well.