Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for successful haproxy startup #594

Closed
wants to merge 1 commit into from

Conversation

PKizzle
Copy link
Contributor

@PKizzle PKizzle commented Dec 15, 2023

Instead of assuming that haproxy API server is already reachable when starting up kubernetes-ingress wait until it is available. This fixes startup issues for systems running on low-end hardware where kubernetes-ingress would go into a crash-loop as haproxy never starts up fast enough.

@oktalz
Copy link
Member

oktalz commented Dec 18, 2023

hi @PKizzle ,

thx for the PR.
if this is the issue on low-end hardware I agree we should address it.
However, we can't remove inotify from aux file, that file is allowed to be changed over time

@PKizzle
Copy link
Contributor Author

PKizzle commented Dec 18, 2023

Could you explain what you mean with the removal of inotify from the aux file? I am unable to find it in my code changes 😅

Edit: Are you maybe referring to my other PR?
Edit 2: Now I understand. It is regarding the commit 66b9efd. I have added the fsnotify based monitoring myself. As there was already an alternative change detection system in place I have removed the feature again.
Edit 3: I have removed the confusing commit history and merged it into one

@PKizzle PKizzle force-pushed the feature/wait-for-api branch from 66b9efd to 6eb3430 Compare December 18, 2023 16:12
@dkorunic
Copy link
Member

This is much easier to fix with relying on S6 dependancies in S6 overlay 3.1 and with fine-tuning startupProbe. failureThreshold if needed. The changes here and in #593 bring too much changes for a specific case. I'll close this request and address this in incoming S6 overlay 3.1 overhaul.

@dkorunic dkorunic closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants