Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax BitTiming & BitTimingFd Validation #1618

Merged
merged 5 commits into from
Sep 17, 2023

Conversation

zariiii9003
Copy link
Collaborator

See #1616

@zariiii9003 zariiii9003 requested a review from lumagi June 25, 2023 21:23
@lumagi
Copy link
Collaborator

lumagi commented Jun 29, 2023

I don't have access to a device with a decent screen size at the moment, so I don't think I can support with a review. But do we want the strict mode only to be adjustable in __init__ and not in the class methods? This is only me asking without totally knowing the context.

@zariiii9003
Copy link
Collaborator Author

I don't have access to a device with a decent screen size at the moment, so I don't think I can support with a review. But do we want the strict mode only to be adjustable in __init__ and not in the class methods? This is only me asking without totally knowing the context.

@lumagi Super fast reply after two months:
My thinking was: Whenever the user provides the timings, we give him the option to relax the requirements. But whenever python-can suggests the bit timings, they should be inside the minimum required bit timing ranges for best compatibility.

I added the parameter to a few classmethods in my last commits.

@zariiii9003 zariiii9003 marked this pull request as ready for review August 17, 2023 14:20
@lumagi
Copy link
Collaborator

lumagi commented Sep 9, 2023

That makes sense, thanks for clarifying!

@zariiii9003 zariiii9003 merged commit db177b3 into hardbyte:develop Sep 17, 2023
26 checks passed
@zariiii9003 zariiii9003 deleted the bittiming_ranges branch September 17, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants