improve the "ASCReader" read performance. #1709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve the "ASCReader" performance.
Fix: the test error "error: Item "None" of "Optional[Match[str]]" has no attribute "group" [union-attr]"
style: format code with "Black Code Formatter"
zariiii9003
reviewed
Dec 29, 2023
zariiii9003
reviewed
Dec 29, 2023
* improvement: make regular expression compile result as module constants. --------- Co-authored-by: XXIN <[email protected]>
|
this pull request is a little confusing, so I close it and make a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the
ASCReaderread performance.Use
re.compileto compile the regular expression,thenmatchthe message will faster than directmatchthe message .The read speed is about 30% faster than before.