Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the "ASCReader" read performance. #1717

Merged
merged 6 commits into from
Dec 30, 2023
Merged

improve the "ASCReader" read performance. #1717

merged 6 commits into from
Dec 30, 2023

Conversation

XXIN0
Copy link
Contributor

@XXIN0 XXIN0 commented Dec 30, 2023

Improve the ASCReader read performance.
Use re.compile to compile the regular expression,then match the message will faster than direct match the message .

The read speed is about 30% faster than before.

XXIN0 and others added 6 commits December 22, 2023 16:45
@XXIN0
Update asc.py
486997c 
improve the "ASCReader" performance.
@XXIN0
Update asc.py
17c9c4e 
Fix: the test  error "error: Item "None" of "Optional[Match[str]]" has no attribute "group"  [union-attr]"
@XXIN0
Update asc.py
0c7c6f2 
style: format code with "Black Code Formatter"
@XXIN0
Merge branch 'hardbyte:main' into main
a8e9864
improvement: make regular expression compile result as module constants.
41cff6f
style:format import
9cb66cf
@XXIN0
Copy link
Contributor Author

XXIN0 commented Dec 30, 2023

@zariiii9003
Thanks for reviewing the code. because I don’t understand some of the rules of GitHub very well, the previous PR was a bit messed up by me, so I submitted a new PR . Please review the code when you have free time, thank you.

zariiii9003
zariiii9003 approved these changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@zariiii9003 zariiii9003 merged commit 3f6e951 into hardbyte:main Dec 30, 2023
30 checks passed
@XXIN0 XXIN0 deleted the develop branch December 31, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zariiii9003 zariiii9003 zariiii9003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XXIN0 @zariiii9003