fix: replayClick always being applied
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlan-zw
changed the title
replayClick always being applied
|
Damn good catch, thank you 🙏 |
|
@harlan-zw Thanks for the quick review and merge. |
|
Yup, right now 👍 |
|
Thanks @harlan-zw! this was affecting our project hugely, thanks for the quick merge and release. |
|
Thank you @sauravbv, PRs always welcome for quick review 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
replayClickoption. Until now, the replay script was always added to the HTML source regardless the option was set to false or not used. Hence, all click or touch events before hydration is replayed.This solves a couple of things:
replayClickoption will work as intended (false) as defaultLinked Issues
Additional context