Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
replayClick
script there is a simple logic mistake where click is being triggered on nonClick
events, rather than theClick
events.ReplayClick should trigger on click events and not the other events like scroll, mousemove etc
Linked Issues
I haven't raised an issue since it's a simple fix, but below is a replication of how this can be an issue.
If a page has a huge element with a href or click action, just hovering or moving mouse over this element before hydration event can cause the click to trigger.
I think the logic got messed up in the below commit where before if the click event type was of
click
, function was returned.24f05c7
Issue replicated: https://stackblitz.com/edit/nuxt-starter-n7nihz?file=app.vue
Additional context
Thanks for this amazing package. I hope to contribute more :)