fix(core): set extraHttpHeaders and cookies on page change

Fixes #92 (maybe)
harlan-zw · May 15, 2023 · 7dd92c9 · 7dd92c9
1 parent ee608b7
commit 7dd92c9
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/packages/core/src/puppeteer/tasks/lighthouse.ts b/packages/core/src/puppeteer/tasks/lighthouse.ts
@@ -97,15 +97,13 @@ export const runLighthouseTask: PuppeteerTask = async (props) => {
   if (resolvedConfig.auth)
     await page.authenticate(resolvedConfig.auth)
 
-  if (resolvedConfig.cookies)
-    await page.setCookie(...resolvedConfig.cookies)
-
-  if (resolvedConfig.extraHeaders)
-    await page.setExtraHTTPHeaders(resolvedConfig.extraHeaders)
-
   // Wait for Lighthouse to open url, then allow hook to run
   browser.on('targetchanged', async (target) => {
     const page = await target.page()
+    if (resolvedConfig.cookies)
+      await page.setCookie(...resolvedConfig.cookies)
+    if (resolvedConfig.extraHeaders)
+      await page.setExtraHTTPHeaders(resolvedConfig.extraHeaders)
     if (page)
       await hooks.callHook('puppeteer:before-goto', page)
   })