Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: project settings page #1066

Merged
merged 3 commits into from
Feb 19, 2025
Merged

refactor: project settings page #1066

merged 3 commits into from
Feb 19, 2025

Conversation

3em
Copy link
Collaborator

@3em 3em commented Feb 10, 2025

  • Renamed useTranslation[s]Store to useTranslationStore for consistency
  • Renamed ProjectSettingsPage to ProjectSettingsTabNav according to ProfileSettingsTabNav
  • Connected components to the translation store
  • Renamed duplicated component (SettingsLayout) properly - ProfileSettingsLayout and ProjectSettingsLayout
  • Fixed disabled state for Label component
  • Refactored Legend component and added it to the Project Settings Page
  • Fixed a bunch of margins/paddings

image

@3em 3em requested a review from knagurski as a code owner February 10, 2025 11:26
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 3em
❌ ankormoreankor
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 1c746f7
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67b5c4403965e70008d30785
😎 Deploy Preview https://deploy-preview-1066--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 1c746f7
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67b5c440d69783000743179c
😎 Deploy Preview https://deploy-preview-1066--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3em 3em force-pushed the project-settings-review branch 2 times, most recently from f848817 to 752d9d2 Compare February 13, 2025 07:28
@3em 3em force-pushed the project-settings-review branch 3 times, most recently from e43d2de to a898b5e Compare February 19, 2025 11:32
@3em 3em merged commit 2f9bb0e into main Feb 19, 2025
14 checks passed
@3em 3em deleted the project-settings-review branch February 19, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants