-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added docs for ui components #1070
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
700e4a5
to
da13a7a
Compare
Can we break this up into different PRs? This is too much to review without blindly rubber-stamping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These appear to be mass-produced AI-generated docs with issues. All docs additions should be their own PRs and need to be checked over to make sure they're correct (e.g. the first component is BranchSelector
, but is in a file called branch-chooser
with Branch Chooser
referenced etc).
agreed with the bocker here. we need to ensure correctness and basic quality. individual PRs would help with that. however, we do need to get some basic docs ready for a majority of components, because we want to open up the component library to other teams very soon. AI can be a good way to kickstart something, but we should not be blindly committing "AI Slop". |
@knagurski Actually the file-name is |
@knagurski @abhinavrastogi-harness
we may have to re-look at the text content being generated which I did not give much importance to, |
No description provided.