Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added theme support for icons #975

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: added theme support for icons #975

wants to merge 2 commits into from

Conversation

3em
Copy link
Collaborator

@3em 3em commented Feb 5, 2025 •
edited
Loading

  • Added theme support for icons
  • Added ThemeProvider context to UI
  • Added icons with light mode
  • Fixed useThemeStore at design-system

image

@3em 3em requested a review from knagurski as a code owner February 5, 2025 08:34
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit ed91d0c
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67aefb91f6a15300082796ee
😎 Deploy Preview https://deploy-preview-975--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit ed91d0c
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67aefb91deef550008cfa161
😎 Deploy Preview https://deploy-preview-975--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@3em 3em force-pushed the feat-themed-icons branch from 82e535d to e0f602c Compare February 5, 2025 08:41
abhinavrastogi-harness
abhinavrastogi-harness reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@abhinavrastogi-harness abhinavrastogi-harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the images which need a light version, are not even "icons" strictly.
i think we need to discuss and come up with a better approach for handling this.

@3em 3em force-pushed the feat-themed-icons branch 3 times, most recently from 9c06f1b to da15041 Compare February 14, 2025 08:10
@3em 3em force-pushed the feat-themed-icons branch from da15041 to 7875dad Compare February 14, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavrastogi-harness abhinavrastogi-harness abhinavrastogi-harness left review comments

@knagurski knagurski Awaiting requested review from knagurski knagurski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3em @CLAassistant @abhinavrastogi-harness