Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left navigation bar - Add horizontal divider style (change won't be visible until someone adds the divider) #8724

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

lenasano
Copy link
Collaborator

@lenasano lenasano commented Nov 28, 2024

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: Add styling for left nav menu horizontal divider / design source: Figma file
  • Jira/GitHub Issue numbers (if any): N/A
  • Preview links/images (Internal contributors only): See example New to IaCM? divider on IaCM page / See also comment below.

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@bot-gitexp-user
Copy link

bot-gitexp-user commented Nov 29, 2024

Current Draft URL is: https://6749c0cfcdc2ec8ba6f82741--harness-developer.netlify.app

Note to reviewer:
This preview shows the left nav menu horizontal divider at this link: https://6749c0cfcdc2ec8ba6f82741--harness-developer.netlify.app/docs/infrastructure-as-code-management

image

@harness harness deleted a comment from bot-gitexp-user Nov 29, 2024
@bot-gitexp-user
Copy link

bot-gitexp-user commented Nov 29, 2024

Current Draft URL is: https://6749ce19e88c34b0cbe3fe4b--harness-developer.netlify.app

☝🏼 This (latest) revision does not show any left nav menu horizontal dividers in any module. Instead, this PR adds the css styling so that any module can add a divider if they would like to.

@harness harness deleted a comment from bot-gitexp-user Nov 29, 2024
@rohanmaharjan100
Copy link
Collaborator

@lenasano Everything looks great! How about adding style for dark mode as well?

@harness harness deleted a comment from bot-gitexp-user Dec 1, 2024
@bot-gitexp-user
Copy link

bot-gitexp-user commented Dec 1, 2024

@bot-gitexp-user
Copy link

bot-gitexp-user commented Dec 1, 2024

Current Draft URL is: https://674c6245cdc2ec85c4f82626--harness-developer.netlify.app

☝🏼 This is the latest link, again without visual changes.

@lenasano lenasano enabled auto-merge December 2, 2024 06:17
@lenasano lenasano merged commit 3c2dbe8 into main Dec 3, 2024
2 checks passed
@lenasano lenasano deleted the nav_bar_horizontal_div_style branch December 3, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants