-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left navigation bar - Add horizontal divider style (change won't be visible until someone adds the divider) #8724
Conversation
This reverts commit 2690cdf.
See the docs/infrastructure-as-code-management page for a demo of the divider source: https://docusaurus.io/docs/sidebar/items#sidebar-item-html
Current Draft URL is: https://6749c0cfcdc2ec8ba6f82741--harness-developer.netlify.app Note to reviewer: |
Current Draft URL is: https://6749ce19e88c34b0cbe3fe4b--harness-developer.netlify.app ☝🏼 This (latest) revision does not show any left nav menu horizontal dividers in any module. Instead, this PR adds the css styling so that any module can add a divider if they would like to. |
@lenasano Everything looks great! How about adding style for dark mode as well? |
Current Draft URL is: https://674c6187e6d0f6848e6bdf61--harness-developer.netlify.app @rohanmaharjan100 You can see dark mode now as well, at https://674c6187e6d0f6848e6bdf61--harness-developer.netlify.app/docs/infrastructure-as-code-management/ |
Current Draft URL is: https://674c6245cdc2ec85c4f82626--harness-developer.netlify.app ☝🏼 This is the latest link, again without visual changes. |
Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description
New to IaCM?
divider on IaCM page / See also comment below.PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged: