Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDS-105745] Added note related to undefined variables in expressions… #9077

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

vishal-av
Copy link
Collaborator

… in NG pipeline

In Harness NG pipelines, undefined variables in expressions will cause a pipeline execution error. Unlike FirstGen pipelines, where undefined variables default to null, NG requires explicit handling of undefined variables.

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: __________________________________
  • Jira/GitHub Issue numbers (if any): ______________________________
  • Preview links/images (Internal contributors only): __________________

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

… in NG pipeline

In Harness NG pipelines, undefined variables in expressions will cause a pipeline execution error. Unlike FirstGen pipelines, where undefined variables default to `null`, NG requires explicit handling of undefined variables.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vishal-av vishal-av enabled auto-merge January 15, 2025 18:41
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://678801680c18801abb7acea1--harness-developer.netlify.app

Copy link
Collaborator

@SushrutHarness SushrutHarness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM, but I'm not a codeowner, so this PR won't merge.

@@ -217,6 +217,12 @@ Additionally, variable values (after evaluation) are limited to 256 KB. Expressi

:::

:::note

In Harness NG pipelines, undefined variables in expressions will cause a pipeline execution error. Unlike FirstGen pipelines, where undefined variables default to `null`, NG requires explicit handling of undefined variables.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In Harness NG pipelines, undefined variables in expressions will cause a pipeline execution error. Unlike FirstGen pipelines, where undefined variables default to `null`, NG requires explicit handling of undefined variables.
In Harness NG pipelines, undefined variables in expressions will cause a pipeline execution error unlike FirstGen pipelines, where undefined variables default to `null`. NG requires explicit handling of undefined variables.

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://678899e6c8572df28fe5440a--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67889daec8572df66fe540e4--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6788af44ab861c404b5260cd--harness-developer.netlify.app

@vishal-av vishal-av merged commit 7fff61d into main Jan 16, 2025
3 checks passed
@vishal-av vishal-av deleted the CDS-105745 branch January 16, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants