techdebt: [CDS-99063]: Allow support to overrdie redis-ha secret ref …

…for auth to redis from agent

templates/_common.tpl

@@ -131,7 +131,7 @@ Create redis name and version as used by the chart label.
 {{- $redisHa := (index .Values "redis-ha") -}}
 {{- if $redisHa.enabled -}}
     {{- if $redisHa.haproxy.enabled -}}
-        {{- printf "%s-haproxy" ($redisHa.fullName) | trunc 63 | trimSuffix "-" -}}
+        {{- printf "%s-%s-haproxy" (index .Values "fullnameOverride") $redisHa.name | trunc 63 | trimSuffix "-" -}}
     {{- end -}}
 {{- else -}}
 {{- printf "%s-%s" (include "argo-cd.fullname" .) .Values.redis.name | trunc 63 | trimSuffix "-" -}}

templates/gitops-agent/deployment.yaml

@@ -87,10 +87,10 @@ spec:
                 name: {{ default "argocd-redis" .Values.externalRedis.existingSecret }}
                 {{- if .Values.externalRedis.host }}
                 key: redis-password
-                optional: true
                 {{- else }}
                 key: auth
                 {{- end }}
+                optional: true
           - name: REDIS_SENTINEL_USERNAME
             valueFrom:
               secretKeyRef:

values.yaml

@@ -401,7 +401,9 @@ redis:
 redis-ha:
   enabled: false
   # This value should be equal to redis-ha.fullname generated and set there from your redis-ha subchart 
-  fullName: ""
+  # This will be used to get redis auth details from given secret name generated from this field
+  # Usually is the same as the value .Values.harness.configmap.argocd.redisHa
+  name: "redis-ha"
   haproxy:
     enabled: true
   # -- Existing Secret to use for redis-ha authentication.