-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Fix: Go Gitlab Project Has Moved #448
Draft
harrisoncramer
wants to merge
40
commits into
develop
Choose a base branch
from
447-new-repository-for-go-gitlab
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scripts for running go tests and git tests
feat: Automatically open fold under cursor, redraw screen with cursor at center
* fix: use body with /mr/draft_notes/publish endpoint * docs: notify about successfully building server
Fixed some bad warnings when the branch was out of date or ahead of the remote tracking branch. --------- Co-authored-by: Jakub F. Bortlík <[email protected]>
Fix: Show draft replies in the correct tree
Fix: Use correct name for emoji
fix: fixes wrong GET to gitlab when the URL includes namespacing. Fixes #413.
This required changing Go to 1.23, unless I'm mistaken, which will make this an unfortunate breaking change for downstream users.
harrisoncramer
force-pushed
the
develop
branch
2 times, most recently
from
January 18, 2025 16:23
3b57759
to
3b396a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required changing Go to 1.23, unless I'm mistaken, which will make this an unfortunate breaking change for downstream users. To fix, users will have to update their local Go versions to 1.23.4, as the plugin requires this local version of Go in order to compile.
It's worth looking at shipping precompiled versions of the plugins moving forward to avoid this for end-users in the future.
Fixes #447.
Note: This is a #MAJOR breaking change, that will require users to update their versions of Go locally to latest (1.23.4)