Breaking: Deprecate Delta Reviewer #81
Conversation
|
@johnybx Would you please review this? Should be a pretty straightforward deprecation of all things Delta. |
| @@ -38,7 +38,7 @@ M.add_popup = function(type) | |||
| table.insert(current_ids, choice.id) | |||
| local body = { ids = current_ids } | |||
| job.run_job("/mr/" .. type, "PUT", body, function(data) | |||
| vim.notify(data.message, vim.log.levels.INFO) | |||
| u.notify(data.message, vim.log.levels.INFO) | |||
There was a problem hiding this comment.
Adding this prefixes all messages with gitlab.nvim: which is great for usability IMO
| @@ -22,10 +22,11 @@ return { | |||
| end | |||
| server.build() -- Builds the Go binary if it doesn't exist | |||
| state.setPluginConfiguration() -- Sets configuration from `.gitlab.nvim` file | |||
| state.merge_settings(args) -- Sets keymaps and other settings from setup function | |||
|
|
|||
| if not state.merge_settings(args) then -- Sets keymaps and other settings from setup function | |||
There was a problem hiding this comment.
If the merge_settings function returns false it means there was a fatal error and we do not try to keep running the setup function
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
my bad I just noticed that message is in function.
| @@ -22,10 +22,11 @@ return { | |||
| end | |||
| server.build() -- Builds the Go binary if it doesn't exist | |||
| state.setPluginConfiguration() -- Sets configuration from `.gitlab.nvim` file | |||
| state.merge_settings(args) -- Sets keymaps and other settings from setup function | |||
|
|
|||
| if not state.merge_settings(args) then -- Sets keymaps and other settings from setup function | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -1,42 +0,0 @@ | |||
| -- This Module will pick the reviewer set in the user's | |||
There was a problem hiding this comment.
I personally would maybe leave this here because it nicely abstracts reviewer, we have control over functions which we use elsewhere in code ( assuming we use only things exposed here ) and it will allow for future extensibility if someone else want to support other reviewers ( or build some kind of plugin ).
What do you think ? ( if you feel like it is bad idea feel free to ignore this 👍 )
There was a problem hiding this comment.
Sure, will put it back. No problem, thanks!
This MR removes the Delta reviewer.
It's my strong hunch that nobody is actually using this, and given that we are now adding features specific to Diffview we should deprecate this reviewer so that folks can have the full experience.
I've added guards into the application to alert users using Delta to switch over to Diffview.