Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin [email protected] for check-plugin CI job #1160

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 21, 2024

Summary

fix check-plugin job failed : https://github.com/harvester/dashboard/actions/runs/10969497163/job/30462262664?pr=1151

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #

Occurred changes and/or fixed issues

Technical notes summary

verdaccio v6.0.0 is released yesterday. But requires node >= 18.

I tried update to node 18 or 20, but causes @achrinza/node-ipc complaining node is too new.

Screenshot 2024-09-21 at 12 34 13 PM

@achrinza/node-ipc needs v9.2.5 to be able to run on Node 18. See : vuejs/vue-cli#7424 (comment)

@a110605 a110605 added the Bug Fix Something isn't working label Sep 21, 2024
@a110605 a110605 self-assigned this Sep 21, 2024
@a110605 a110605 changed the title Use node 20 for check plugin CI job Use node 18 for check plugin CI job Sep 21, 2024
@a110605 a110605 changed the title Use node 18 for check plugin CI job Pin [email protected] for check-plugin CI job Sep 21, 2024
@a110605 a110605 added CI/CD and removed Bug Fix Something isn't working labels Sep 23, 2024
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase your PRs

@a110605 a110605 merged commit 71e13fe into harvester:master Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants