Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Binary Serch Alogrithams #320

Merged

Conversation

Goheljay
Copy link

Issue #252

Added Simple Binary Serch Algorithm which works on divided in middle and find the target.
Added Circular Array using Binary search which works:- finding Pivot element and comparing target.
Added Moutain Array using Binary Serch which works:- finding largest element and return it.
Added orderAgnostic Arrayusing Binary Search:- Finding the order of given array and then searching target element

@BudhirajaMadhav @VaibhavPaliwal0007 Please Review my PR.

@VaibhavPaliwal0007
Copy link
Member

Can you make a separate file where you can explain your approach to each question you have solved in this PR. It will be very helpful for others as they will easily understand the code. You can also add comments to your code to make it easy for others to understand.

@Goheljay
Copy link
Author

@VaibhavPaliwal0007 I have added comments in the code. now you can review it.

@Goheljay
Copy link
Author

@VaibhavPaliwal0007 please accept my pull request. so this my pr count in hacktoberfest.

@VaibhavPaliwal0007 VaibhavPaliwal0007 merged commit 097ce10 into hash-define-organization:master Oct 19, 2021
@Goheljay
Copy link
Author

Goheljay commented Oct 23, 2021

binary

@VaibhavPaliwal0007 @achitJ @DhairyaBahl why showing me "Project Excluded" in my PR? please help me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants