Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tool for converting Record Files to Block Stream #389

Merged
merged 17 commits into from
Dec 20, 2024

Conversation

jasperpotts
Copy link
Member

@jasperpotts jasperpotts commented Dec 10, 2024

Command line tool adding extra command for converting Record Files to Block Stream.
Resolves #359

settings.gradle.kts Outdated Show resolved Hide resolved
@jasperpotts jasperpotts marked this pull request as ready for review December 11, 2024 19:56
@jasperpotts jasperpotts requested a review from a team as a code owner December 11, 2024 19:56
@jasperpotts
Copy link
Member Author

Not 100% done yet but made ready for review so the build actions are executed to make sure build works on sever because it as been such a pain to get to build locally.

@jasperpotts jasperpotts changed the title Tool for converting Record Files to Block Stream feat: Tool for converting Record Files to Block Stream Dec 11, 2024
@jsync-swirlds jsync-swirlds added this to the 0.4.0 milestone Dec 12, 2024
@jsync-swirlds jsync-swirlds added the Block Node Tools Additional tools related to, but not part of, the Block Node label Dec 12, 2024
@jasperpotts jasperpotts force-pushed the 359-tool-convert-record-to-block branch from 9b15159 to 0c8dac0 Compare December 20, 2024 00:09
tools/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jjohannes jjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review for the Gradle configuration part

tools/build.gradle.kts Outdated Show resolved Hide resolved
tools/build.gradle.kts Outdated Show resolved Hide resolved
tools/build.gradle.kts Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
@jjohannes
Copy link
Contributor

Comment on Gradle setup:
I will revisit the "classpath-based" setup of the "tools" project this PR introduces as part of hiero-ledger/hiero-gradle-conventions#53

ata-nas
ata-nas previously approved these changes Dec 20, 2024
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Some comments from @jjohannes about gradle.

Also, CI/CD fails (this should be resolved otherwise it will keep failing for everyone if merged):

FAILURE: Build failed with an exception.

[Incubating] Problems report is available at: file:///home/runner/_work/hedera-block-node/hedera-block-node/build/reports/problems/problems-report.html
* What went wrong:
Could not determine the dependencies of task ':tools:shadowJar'.
> Could not resolve all files for configuration ':tools:runtimeClasspath'.
   > Failed to transform stream-0.3.0-SNAPSHOT.jar (project :stream) to match attributes {artifactType=jar, javaModule=true, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.jvm.version=21, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime}.
      > Execution failed for ExtraJavaModuleInfoTransform: /home/runner/_work/hedera-block-node/hedera-block-node/stream/build/libs/stream-0.3.0-SNAPSHOT.jar.
         > Transform output /home/runner/_work/hedera-block-node/hedera-block-node/stream/build/libs/stream-0.3.0-SNAPSHOT.jar must exist.

Seems to be related to the task :tools:shadowJar

tool.sh Outdated Show resolved Hide resolved
tools/build.gradle.kts Show resolved Hide resolved
tools/docs/quickstart.md Show resolved Hide resolved
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jasperpotts jasperpotts dismissed jjohannes’s stale review December 20, 2024 18:08

Made changes and it is late for him to approve

@jasperpotts jasperpotts merged commit ac58d0b into main Dec 20, 2024
7 checks passed
@jasperpotts jasperpotts deleted the 359-tool-convert-record-to-block branch December 20, 2024 18:08
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (3ad4efc) to head (ac83a5b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #389   +/-   ##
=========================================
  Coverage     96.77%   96.77%           
  Complexity      409      409           
=========================================
  Files            82       82           
  Lines          1458     1458           
  Branches         90       90           
=========================================
  Hits           1411     1411           
  Misses           34       34           
  Partials         13       13           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Tools Additional tools related to, but not part of, the Block Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a tool to convert existing record files to block files
5 participants