-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tool for converting Record Files to Block Stream #389
Conversation
Not 100% done yet but made ready for review so the build actions are executed to make sure build works on sever because it as been such a pain to get to build locally. |
tools/src/main/java/com/hedera/block/tools/commands/record2blocks/model/SignatureFile.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
… build. Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
9b15159
to
0c8dac0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for the Gradle configuration part
Comment on Gradle setup: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Some comments from @jjohannes about gradle.
Also, CI/CD fails (this should be resolved otherwise it will keep failing for everyone if merged):
FAILURE: Build failed with an exception.
[Incubating] Problems report is available at: file:///home/runner/_work/hedera-block-node/hedera-block-node/build/reports/problems/problems-report.html
* What went wrong:
Could not determine the dependencies of task ':tools:shadowJar'.
> Could not resolve all files for configuration ':tools:runtimeClasspath'.
> Failed to transform stream-0.3.0-SNAPSHOT.jar (project :stream) to match attributes {artifactType=jar, javaModule=true, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.jvm.version=21, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime}.
> Execution failed for ExtraJavaModuleInfoTransform: /home/runner/_work/hedera-block-node/hedera-block-node/stream/build/libs/stream-0.3.0-SNAPSHOT.jar.
> Transform output /home/runner/_work/hedera-block-node/hedera-block-node/stream/build/libs/stream-0.3.0-SNAPSHOT.jar must exist.
Seems to be related to the task :tools:shadowJar
tools/src/main/java/com/hedera/block/tools/commands/record2blocks/gcp/AddNewerBlockTimes.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
Signed-off-by: jasperpotts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Made changes and it is late for him to approve
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
=========================================
Coverage 96.77% 96.77%
Complexity 409 409
=========================================
Files 82 82
Lines 1458 1458
Branches 90 90
=========================================
Hits 1411 1411
Misses 34 34
Partials 13 13 |
Command line tool adding extra command for converting Record Files to Block Stream.
Resolves #359