Fixes try catch tests and remove unecessary asseritons #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 32 32
Lines 2599 2599
Branches 529 529
=======================================
Hits 2031 2031
Misses 402 402
Partials 166 166 ☔ View full report in Codecov by Sentry. |
konstantinabl
force-pushed
the
1371-update-trycatch-test-logic-to-verify-errors-are-thrown
branch
3 times, most recently
from
a99932a to
c9c08a7
Compare
|
Added temporary fix in dapp-example/tests/e2e/specs/index.spec.js due to issue in synpress library: |
konstantinabl
requested review from
a team,
AlfredoG87,
ebadiere and
Nana-EC
as code owners
Nana-EC
added
enhancement
konstantinabl
force-pushed
the
1371-update-trycatch-test-logic-to-verify-errors-are-thrown
branch
3 times, most recently
from
4783703 to
411488a
Compare
georgi-l95
approved these changes
Jul 5, 2023
added 4 commits
July 5, 2023 11:42
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]>
added 4 commits
July 5, 2023 11:42
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
konstantinabl
force-pushed
the
1371-update-trycatch-test-logic-to-verify-errors-are-thrown
branch
from
411488a to
1e3602e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Ivo-Yankov
deleted the
1371-update-trycatch-test-logic-to-verify-errors-are-thrown
branch
mshakeg
pushed a commit
to mshakeg/hedera-json-rpc-relay
that referenced
this pull request
Oct 18, 2023
* Fixes try catch tests and remove unecessary asseritons Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds missing dependency Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes accidental deletion Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> * Moves chai import to index; remove uneccessary imports Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> * Removes duplication Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> * Fixes accidental commit of comments in index Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> * Removes unexpected parameter passed to function Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> * Adds temporary fix in dapp due to synpress issue Signed-off-by: Konstantina Blazhukova <[email protected]> --------- Signed-off-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Konstantina Blazhukova <[email protected]> Co-authored-by: Konstantina Blazhukova <[email protected]> Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently in the acceptance tests try catch logic is used, however we do not check whether an error is actually thrown and we enter the catch. Therefore, this PR changes the logic so we take the maximum of the chai library in order to make the tests effective and intuitive
What is included