-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add keys()
method to CacheService
#2931
Conversation
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
keys()
method to ICacheClientkeys()
method to CacheService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Also looks like we're missing tests for these new updates.
…) in localLRUCache#keys() Signed-off-by: Victor Yanev <[email protected]>
…pec.ts Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…tent Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just make sure CI passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
- Coverage 86.37% 84.21% -2.16%
==========================================
Files 59 56 -3
Lines 3904 3769 -135
Branches 807 771 -36
==========================================
- Hits 3372 3174 -198
- Misses 281 356 +75
+ Partials 251 239 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
CacheService
which retrieves all keys in the cache that match the given pattern.keys()
method to theICacheClient
interfaceRedisClient
andLocalLRUCache
(all implementations of theICacheClient
)Notes for reviewer:
Checklist