feat: Add new metrics for spending plans #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
victor-yanev
changed the base branch from
main
to
update-cache-client-with-method-for-keys
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…) in localLRUCache#keys() Signed-off-by: Victor Yanev <[email protected]>
…pec.ts Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…tent Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…metrics-for-spending-plans Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Base automatically changed from
update-cache-client-with-method-for-keys
to
main
September 5, 2024 16:56
victor-yanev
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
natanasow
previously approved these changes
Sep 9, 2024
packages/relay/src/lib/db/repositories/hbarLimiter/hbarSpendingPlanRepository.ts
Show resolved
Hide resolved
quiet-node
reviewed
Sep 9, 2024
packages/relay/src/lib/db/repositories/hbarLimiter/hbarSpendingPlanRepository.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/db/repositories/hbarLimiter/hbarSpendingPlanRepository.ts
Show resolved
Hide resolved
Signed-off-by: Victor Yanev <[email protected]>
…ns' into add-new-metrics-for-spending-plans Signed-off-by: Victor Yanev <[email protected]>
quiet-node
approved these changes
Sep 10, 2024
packages/relay/src/lib/db/repositories/hbarLimiter/hbarSpendingPlanRepository.ts
Show resolved
Hide resolved
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 89.59% 89.53% -0.06%
==========================================
Files 40 56 +16
Lines 3056 3794 +738
Branches 632 772 +140
==========================================
+ Hits 2738 3397 +659
- Misses 274 350 +76
- Partials 44 47 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds new metrics for spending plans which are tracked dynamically in the
HbarLimitService:dailyUniqueSpendingPlansCounter: Tracks the number of unique spending plans used daily. (per subscription type)averageDailySpendingPlanUsagesGauge: Tracks the average daily spending plan usages. (per subscription type)Related issue(s):
Fixes #2933
Notes for reviewer:
Checklist