Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Preemptive Rate Limitting for HFS Transactions to hbar-limiter desgin doc #2949

Conversation

quiet-node
Copy link
Member

Description:
This PR adds the preemptive rate limitting logic to the desgin doc.

Related issue(s):

Fixes #2948

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Sep 5, 2024
@quiet-node quiet-node added this to the 0.56.0 milestone Sep 5, 2024
@quiet-node quiet-node self-assigned this Sep 5, 2024
@quiet-node quiet-node requested a review from a team as a code owner September 5, 2024 17:54
Copy link

github-actions bot commented Sep 5, 2024

Acceptance Tests

  19 files  255 suites   28m 58s ⏱️
603 tests 595 ✔️ 4 💤 4
764 runs  756 ✔️ 4 💤 4

Results for commit 4ac0f10.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node changed the title doc: added Preemptive Rate Limitting for HFS Transactions to hbar-limiter.md doc docs: added Preemptive Rate Limitting for HFS Transactions to hbar-limiter.md doc Sep 6, 2024
@quiet-node quiet-node changed the title docs: added Preemptive Rate Limitting for HFS Transactions to hbar-limiter.md doc docs: added Preemptive Rate Limitting for HFS Transactions to hbar-limiter desgin doc Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Tests

       3 files     272 suites   20s ⏱️
1 276 tests 1 275 ✔️ 1 💤 0
1 288 runs  1 287 ✔️ 1 💤 0

Results for commit 4ac0f10.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Copy link

sonarqubecloud bot commented Sep 9, 2024

@quiet-node quiet-node merged commit 3648684 into main Sep 9, 2024
43 checks passed
@quiet-node quiet-node deleted the 2948-hbar-rate-limit-redesign-add-preemptive-rate-limitting-logic-to-hbar-limiter-doc branch September 9, 2024 18:24
@quiet-node quiet-node added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (df4d02e) to head (4ac0f10).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2949   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files          56       56           
  Lines        3770     3770           
  Branches      771      771           
=======================================
  Hits         3182     3182           
  Misses        351      351           
  Partials      237      237           
Flag Coverage Δ
relay 84.48% <ø> (ø)
server 83.05% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HBAR Rate Limit Redesign] add preemptive rate limitting logic to hbar-limiter doc
3 participants