feat: implement preemptive rate limitting logic to HbarLimitService class #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
victor-yanev
requested changes
Sep 9, 2024
packages/relay/src/lib/services/hbarLimitService/IHbarLimitService.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/services/hbarLimitService/IHbarLimitService.ts
Outdated
Show resolved
Hide resolved
quiet-node
force-pushed
the
2937-hbar-rate-limit-redesign-implement-preemtive-rate-limit-logic-to-hbarlimitservice-II
branch
from
d3fe68c to
a60a80b
Compare
quiet-node
changed the title
victor-yanev
requested changes
Sep 10, 2024
packages/relay/tests/lib/services/hbarLimitService/hbarLimitService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/tests/lib/services/hbarLimitService/hbarLimitService.spec.ts
Show resolved
Hide resolved
packages/relay/tests/lib/services/hbarLimitService/hbarLimitService.spec.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/services/hbarLimitService/IHbarLimitService.ts
Outdated
Show resolved
Hide resolved
quiet-node
force-pushed
the
2937-hbar-rate-limit-redesign-implement-preemtive-rate-limit-logic-to-hbarlimitservice-II
branch
from
86afa7a to
336d55b
Compare
…vice class Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
2937-hbar-rate-limit-redesign-implement-preemtive-rate-limit-logic-to-hbarlimitservice-II
branch
from
daa961b to
da4d324
Compare
|
victor-yanev
approved these changes
Sep 12, 2024
ebadiere
approved these changes
Sep 12, 2024
quiet-node
deleted the
2937-hbar-rate-limit-redesign-implement-preemtive-rate-limit-logic-to-hbarlimitservice-II
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
- Coverage 89.64% 89.54% -0.11%
==========================================
Files 40 56 +16
Lines 3080 3796 +716
Branches 633 775 +142
==========================================
+ Hits 2761 3399 +638
- Misses 275 350 +75
- Partials 44 47 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the preemptive rate-limiting logic in
HbarLimitService.shouldLimit()by comparing the total expenses with the estimated transaction fee.Fixes #2937