Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): enhanced logging upon receiving responses from the Mirror Node server #3422

Conversation

quiet-node
Copy link
Member

Description:
This PR enhances logging in the Relay to provide more detailed information when receiving responses from the Mirror Node server. The improved logs include critical context about the Mirror Node call and error-specific details to assist in debugging issues.

Related issue(s):

Fixes #3421

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Jan 26, 2025
@quiet-node quiet-node self-assigned this Jan 26, 2025
@quiet-node quiet-node requested review from a team as code owners January 26, 2025 03:22
@quiet-node quiet-node requested a review from simzzz January 26, 2025 03:22
@quiet-node quiet-node linked an issue Jan 26, 2025 that may be closed by this pull request
@quiet-node quiet-node added this to the 0.64.2 milestone Jan 26, 2025
Copy link

github-actions bot commented Jan 26, 2025

Test Results

 19 files  ± 0  274 suites  +29   33m 36s ⏱️ -56s
613 tests + 1  608 ✅ + 4  4 💤 ±0  1 ❌  - 3 
664 runs   - 39  659 ✅  - 36  4 💤 ±0  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit 76c0394. ± Comparison against base commit fe6c0cf.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit 373f1dc into main Jan 27, 2025
47 of 48 checks passed
@quiet-node quiet-node deleted the 3421-improve-relay-logging-to-capture-invalid-timestamp-details branch January 27, 2025 15:37
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (fe6c0cf) to head (76c0394).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
+ Coverage   85.20%   85.22%   +0.02%     
==========================================
  Files          69       69              
  Lines        4711     4711              
  Branches     1048     1048              
==========================================
+ Hits         4014     4015       +1     
  Misses        397      397              
+ Partials      300      299       -1     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 79.21% <0.00%> (ø)
server 83.30% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts 88.31% <100.00%> (ø)

... and 3 files with indirect coverage changes

quiet-node added a commit that referenced this pull request Jan 27, 2025
quiet-node added a commit that referenced this pull request Jan 27, 2025
…ving responses from the Mirror Node server (#3422) to release/0.64 (#3426)

chore(logging): enhanced logging upon receiving responses from the Mirror Node server (#3422)

Signed-off-by: Logan Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Relay Logging to Capture Invalid Timestamp Details
3 participants