HIP-1056 Block File Reader #10072
Open
HIP-1056 Block File Reader #10072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
xin-hedera
commented
Jan 9, 2025
| @@ -37,7 +37,8 @@ package com.hedera.mirror.common.domain.transaction; | |||
| public record BlockItem(Transaction transaction, | |||
| TransactionResult transactionResult, | |||
| List<TransactionOutput> transactionOutput, // Note: List may be empty | |||
| Optional<StateChanges> stateChanges) implements StreamItem {} | |||
| List<StateChanges> stateChanges // Note: List may be empty | |||
There was a problem hiding this comment.
two reasons to make the change
- it's unclear from the doc if there should be strictly at most 1 statechanges for a transaction or not
- there are always non-transactional state changes before block proof, in case the last event in the last round has an event transaction, there will be more than 1 statechanges; it's unnecessary for the reader to sort out which statechanges belong to a transaction, and which belong to the event transaction.
Signed-off-by: Xin Li <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10072 +/- ##
============================================
+ Coverage 92.21% 92.22% +0.01%
- Complexity 7858 7896 +38
============================================
Files 956 958 +2
Lines 32938 33099 +161
Branches 4151 4170 +19
============================================
+ Hits 30373 30525 +152
- Misses 1588 1593 +5
- Partials 977 981 +4 ☔ View full report in Codecov by Sentry. |
xin-hedera
commented
Jan 9, 2025
| @@ -43,9 +44,6 @@ public class BlockFile implements StreamFile<BlockItem> { | |||
| // Used to generate block hash | |||
| private BlockProof blockProof; | |||
|
|
|||
| // Contained within the last StateChange of the block, contains hashes needed to generate the block hash | |||
There was a problem hiding this comment.
we have the following two hash leaves
- previous hash from
BlockHeader - start of block state hash from
BlockProof
The other two are calculated from input block items merkle tree and output block item merkle tree, so we don't need BlockStreamInfo
xin-hedera
commented
Jan 9, 2025
...rror-importer/src/main/java/com/hedera/mirror/importer/reader/block/BlockRootHashDigest.java
Outdated
Show resolved
Hide resolved
coverage Signed-off-by: Xin Li <[email protected]>
...ror-importer/src/main/java/com/hedera/mirror/importer/reader/block/ProtoBlockFileReader.java
Show resolved
Hide resolved
...ror-importer/src/main/java/com/hedera/mirror/importer/reader/block/ProtoBlockFileReader.java
Show resolved
Hide resolved
Signed-off-by: Xin Li <[email protected]>
Signed-off-by: Xin Li <[email protected]>
xin-hedera
commented
Jan 10, 2025
| @@ -60,6 +58,8 @@ public class BlockFile implements StreamFile<BlockItem> { | |||
| @ToString.Exclude | |||
| private String hash; | |||
|
|
|||
| private Long index; | |||
There was a problem hiding this comment.
add back the index field so we have a setter which makes testing easier. Not really benefit test cases in this PR, however it makes the block stream verifier PR tests easier so as to just set the index, instead of crafting a proper BlockHeader with the correct block number.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds block file reader to read block stream files as defined by HIP-1056
ProtoBlockFileReaderBlockRootHashDigestto calculate block file's root hashRelated issue(s):
Fixes #9894
Notes for reviewer:
Checklist