Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto mnemonic matching #1556

Merged
merged 8 commits into from
Feb 20, 2025
Merged

Conversation

SvetBorislavov
Copy link
Contributor

Description:
This pull request creates a page for matching recovery phrases to an external key

Related issue(s):

Fixes #1245

@SvetBorislavov SvetBorislavov requested review from yiliev0 and a team as code owners February 17, 2025 08:44
@SvetBorislavov SvetBorislavov force-pushed the feat-add-auto-mnemonic-matching branch from e6374e1 to 56d8148 Compare February 17, 2025 08:45
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (7ce6c32) to head (2d809cd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         159      159           
  Lines        5958     5958           
  Branches     1095     1098    +3     
=======================================
  Hits         5903     5903           
- Misses         52       55    +3     
+ Partials        3        0    -3     
Files with missing lines Coverage Δ
...src/main/modules/ipcHandlers/localUser/keyPairs.ts 100.00% <100.00%> (ø)
front-end/src/main/services/localUser/keyPairs.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

@SvetBorislavov SvetBorislavov changed the title feat add auto mnemonic matching feat: add auto mnemonic matching Feb 17, 2025
yiliev0
yiliev0 previously approved these changes Feb 17, 2025
Copy link
Contributor

@yiliev0 yiliev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsync-swirlds jsync-swirlds requested review from jbair06 and removed request for jsync-swirlds February 18, 2025 15:32
@SvetBorislavov SvetBorislavov force-pushed the feat-add-auto-mnemonic-matching branch 3 times, most recently from aa35da5 to 0494f21 Compare February 20, 2025 07:31
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov SvetBorislavov force-pushed the feat-add-auto-mnemonic-matching branch from 0494f21 to 2d809cd Compare February 20, 2025 07:31
@jbair06
Copy link
Member

jbair06 commented Feb 20, 2025

LGTM

@SvetBorislavov SvetBorislavov merged commit 724a552 into main Feb 20, 2025
17 checks passed
@SvetBorislavov SvetBorislavov deleted the feat-add-auto-mnemonic-matching branch February 20, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto mnemonic key matching
3 participants