Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: public key import and nicknames #1573

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

icoxxx
Copy link
Contributor

@icoxxx icoxxx commented Feb 21, 2025

Description:
This PR introduces a new feature: importing public keys and assigning them a nickname.
Key Additions:

  • Local Database: Added a new entity to store public keys and their nicknames.
  • CRUD Operations: Implemented functions to handle create, read, update, and delete operations.
  • UI Integration: Added a section in Settings → Public Keys for managing imported keys.
  • Allow the user to upload a zip or directory of public keys.
  • UI Updates: Public keys are now displayed properly in TransactionDetails, Accounts, and ContactList pages and reusable components.

Backend Enhancements:

  • Introduced a new endpoint in users.controller and a function to handle it in users.service. Allowing to check whether a public key owner exists within the organization without fetching and filtering all users.
  • Unit Tests: Added test coverage for the new endpoint and service function.

PS: This is a fairly large feature, so I might have missed something - feel free to ping me if you spot anything :)

Related issue(s):
#1428 #1537

@icoxxx icoxxx added this to the v0.10 milestone Feb 21, 2025
@icoxxx icoxxx requested a review from jbair06 February 21, 2025 17:27
@icoxxx icoxxx self-assigned this Feb 21, 2025
@icoxxx icoxxx requested review from SvetBorislavov, yiliev0 and a team as code owners February 21, 2025 17:27
@icoxxx icoxxx linked an issue Feb 21, 2025 that may be closed by this pull request
@SvetBorislavov SvetBorislavov force-pushed the 1428-allow-public-key-import-and-nicknames branch from 3ed01ed to 3da134f Compare February 24, 2025 07:53
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (0c1bfae) to head (815e329).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1573      +/-   ##
==========================================
+ Coverage   99.07%   99.10%   +0.02%     
==========================================
  Files         159      161       +2     
  Lines        5959     6148     +189     
  Branches     1101     1146      +45     
==========================================
+ Hits         5904     6093     +189     
  Misses         52       52              
  Partials        3        3              
Files with missing lines Coverage Δ
back-end/apps/api/src/users/users.controller.ts 100.00% <100.00%> (ø)
back-end/apps/api/src/users/users.service.ts 100.00% <100.00%> (ø)
...nd/src/main/modules/ipcHandlers/localUser/index.ts 100.00% <100.00%> (ø)
...modules/ipcHandlers/localUser/publicKeyMappings.ts 100.00% <100.00%> (ø)
front-end/src/main/services/localUser/index.ts 100.00% <100.00%> (ø)
...nd/src/main/services/localUser/publicKeyMapping.ts 100.00% <100.00%> (ø)

Impacted file tree graph

@icoxxx icoxxx force-pushed the 1428-allow-public-key-import-and-nicknames branch from 2dbb6bf to f81f337 Compare February 24, 2025 15:49
@icoxxx icoxxx linked an issue Feb 25, 2025 that may be closed by this pull request
@icoxxx icoxxx requested a review from jbair06 February 25, 2025 20:42
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
icoxxx and others added 7 commits February 26, 2025 12:19
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
Signed-off-by: Hristiyan <[email protected]>
@icoxxx icoxxx force-pushed the 1428-allow-public-key-import-and-nicknames branch from 6d47320 to 554ddb0 Compare February 26, 2025 10:19
Signed-off-by: Hristiyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complex Key viewing issues Allow public key import and nicknames
3 participants