Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: required public keys #1579

Conversation

icoxxx
Copy link
Contributor

@icoxxx icoxxx commented Feb 25, 2025

Fix for excluding canceled/expired transactions within a group, which resolves the issue of the 'Sign All' button persisting on the screen.

Related issue(s):
#1559

Signed-off-by: Hristiyan <[email protected]>
@icoxxx icoxxx requested review from SvetBorislavov, yiliev0 and a team as code owners February 25, 2025 12:52
@icoxxx icoxxx requested a review from jsync-swirlds February 25, 2025 12:52
@icoxxx icoxxx linked an issue Feb 25, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (4ec1468) to head (4838ac4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1579   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         159      159           
  Lines        5959     5959           
  Branches     1093     1101    +8     
=======================================
  Hits         5904     5904           
  Misses         55       55           

Impacted file tree graph

Copy link
Contributor

@yiliev0 yiliev0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, LGTM

@SvetBorislavov SvetBorislavov merged commit 0c1bfae into main Feb 25, 2025
17 checks passed
@SvetBorislavov SvetBorislavov deleted the 1559-sign-all-button-visible-despite-all-transactions-processed branch February 25, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sign All" button visible despite all transactions processed
3 participants