Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix warnings in ClusterCommand #1546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix warnings in ClusterCommand #1546

wants to merge 1 commit into from
+246 −152

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Feb 25, 2025 •
edited
Loading

Description

  • added interfaces for ClusterCommandTasks and ClusterCommandHandlers
  • removed usage of the listr2 task wrapper Task
  • added types to have type-safety
  • remove lint warnings

Related Issues

@instamenta instamenta self-assigned this Feb 25, 2025
@instamenta instamenta requested review from leninmehedy and a team as code owners February 25, 2025 22:00
@instamenta instamenta linked an issue Feb 25, 2025 that may be closed by this pull request
chore: fix warnings in ClusterCommand #1542
Open
@instamenta instamenta added the PR: Needs Team Approval A pull request that needs review from a team member. label Feb 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   62 suites  ±0   1s ⏱️ -3s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 607192d. ± Comparison against base commit b1f7c4d.

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   62 suites  ±0   3s ⏱️ ±0s
241 tests ±0  241 ✅ ±0  0 💤 ±0  0 ❌ ±0 
250 runs  ±0  250 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 607192d. ± Comparison against base commit b1f7c4d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas

At least 1 approving review is required to merge this pull request.

Assignees

@instamenta instamenta

Labels
PR: Needs Team Approval A pull request that needs review from a team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: fix warnings in ClusterCommand
1 participant
@instamenta