feat: 🎸 scope picker component #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lisbet-alvarez
commented
Feb 11, 2025
lisbet-alvarez
commented
Feb 11, 2025
…/boundary-ui into scope-picker-component
lisbet-alvarez
dismissed stale reviews from cameronperera and calcaide
via
1b3ab01
ZedLi
previously approved these changes
Feb 19, 2025
hashicc
reviewed
Feb 19, 2025
There was a problem hiding this comment.
Everything looks great! The component looks really good and the test coverage was really well done and easy to follow.
I think it would be valuable to add an assertion that the checkmark is represented in the dropdown for the actively selected scope.
The only other thing I think is worth checking is using the global scope ember model in the tests
lisbet-alvarez
dismissed stale reviews from cameronperera, DhariniJeeva, and ZedLi
via
6d1237c
ZedLi
previously approved these changes
Feb 20, 2025
ZedLi
approved these changes
Feb 20, 2025
cameronperera
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade hds to newest version because the
@matchToggleWidthoption was added in 4.14 and that is needed for scope picker component.Create scope picker component & add integration tests.
Screenshots (if appropriate)
Checklist