-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix CI: Updated upload-artifact and download-artifact to v4 (#22127)
* Updated upload-artifact from v3 to v4 * Updated download-artifact from v3 to v4 * Ge * Update CODEOWNERS * Update CODEOWNERS
- Loading branch information
1 parent
7c48c32
commit fcc972e
Showing
12 changed files
with
50 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,6 +85,14 @@ jobs: | |
| ulimit -Sa | ||
| echo "Hard limits" | ||
| ulimit -Ha | ||
| # upload-artifact requires a unique ID per run. These steps will be repeated with the matrix run, and other unit tests | ||
| # will also overlap with the names here. We use a random string rather than trying to do trickery | ||
| # with the package matrix. | ||
| - id: generate-matrix-id | ||
| run: | | ||
| MATRIX_RUN_ID=$(head /dev/urandom | tr -dc A-Z | head -c8) | ||
| echo "The matrix run ID is $MATRIX_RUN_ID" | ||
| echo "matrix-run-id=$MATRIX_RUN_ID" >> "$GITHUB_OUTPUT" | ||
| - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # [email protected] | ||
| # NOTE: This step is specifically needed for ENT. It allows us to access the required private HashiCorp repos. | ||
| - name: Setup Git | ||
|
|
@@ -98,7 +106,7 @@ jobs: | |
| working-directory: ${{inputs.directory}} | ||
| run: go mod download | ||
| - name: Download consul | ||
| uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # [email protected] | ||
| uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7 | ||
| with: | ||
| name: ${{inputs.uploaded-binary-name}} | ||
| path: ${{inputs.directory}} | ||
|
|
@@ -166,15 +174,15 @@ jobs: | |
| DD_ENV: ci | ||
| run: datadog-ci junit upload --service "$GITHUB_REPOSITORY" ${{env.TEST_RESULTS}}/gotestsum-report.xml | ||
|
|
||
| - uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # [email protected] | ||
| - uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: test-results | ||
| name: ${{ steps.generate-matrix-id.outputs.matrix-run-id }}-test-results | ||
| path: ${{env.TEST_RESULTS}} | ||
| - uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # [email protected] | ||
| - uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: jsonfile | ||
| name: ${{ steps.generate-matrix-id.outputs.matrix-run-id }}-jsonfile | ||
| path: /tmp/jsonfile | ||
| - name: "Re-run fails report" | ||
| if: ${{ !cancelled() }} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,7 +68,7 @@ jobs: | |
| working-directory: ${{inputs.directory}} | ||
| run: go mod download | ||
| - name: Download consul | ||
| uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # [email protected] | ||
| uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7 | ||
| with: | ||
| name: ${{inputs.uploaded-binary-name}} | ||
| path: ${{inputs.directory}} | ||
|
|
@@ -133,16 +133,22 @@ jobs: | |
| env: | ||
| DD_ENV: ci | ||
| run: datadog-ci junit upload --service "$GITHUB_REPOSITORY" ${{env.TEST_RESULTS}}/gotestsum-report.xml | ||
|
|
||
| - uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # [email protected] | ||
| # upload-artifact requires a unique ID per run. These steps will overlap with other users of the reusable workflow. | ||
| # We use a random string rather than trying to pass in some identifying information. | ||
| - id: generate-run-id | ||
| run: | | ||
| RUN_ID=$(head /dev/urandom | tr -dc A-Z | head -c8) | ||
| echo "The run ID is $RUN_ID" | ||
| echo "run-id=$RUN_ID" >> "$GITHUB_OUTPUT" | ||
| - uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: test-results | ||
| name: ${{ steps.generate-run-id.outputs.run-id }}-test-results | ||
| path: ${{env.TEST_RESULTS}} | ||
| - uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # [email protected] | ||
| - uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
| if: ${{ !cancelled() }} | ||
| with: | ||
| name: jsonfile | ||
| name: ${{ steps.generate-run-id.outputs.run-id }}-jsonfile | ||
| path: /tmp/jsonfile | ||
| - name: "Re-run fails report" | ||
| if: ${{ !cancelled() }} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters