Skip to content

Commit

Permalink
CI and CODEOWNERS update (#85)
Browse files Browse the repository at this point in the history
* simplify ci to ease maintenance

* add a product eng team as a codeowner
  • Loading branch information
schmichael authored Jan 14, 2025
1 parent 7126c55 commit 9687b8b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 14 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/test-and-build.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
name: Test and Build

on:
pull_request:
branches: ["main"]
push:
branches: ["main"]
tags: ["*"]

permissions:
contents: read


jobs:
lint:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
Expand All @@ -27,7 +30,7 @@ jobs:
run: go vet ./...

test:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
go-version:
Expand All @@ -41,13 +44,9 @@ jobs:
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: ${{ matrix.go-version }}
cache: true
- uses: autero1/action-gotestsum@7263b9d73912eec65f46337689e59fac865c425f # v2.0.0
with:
gotestsum_version: 1.9.0

- run: mkdir -p "$TEST_RESULTS"
- run: make test-ci
- uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
path: ${{ env.TEST_RESULTS }}
name: tests-linux
- run: make test
4 changes: 2 additions & 2 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
# More on CODEOWNERS files: https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

# Default owner
* @hashicorp/team-ip-compliance
* @hashicorp/team-ip-compliance @hashicorp/nomad-eng

# Add override rules below. Each line is a file/folder pattern followed by one or more owners.
# Being an owner means those groups or individuals will be added as reviewers to PRs affecting
# those areas of the code.
# Examples:
# /docs/ @docs-team
# *.js @js-team
# *.go @go-team
# *.go @go-team
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ generate:
test:
@go test $(TEST_VERBOSE_ARG) $(GOTEST_PKGS)

test-ci:
@gotestsum --junitfile $(TEST_RESULTS)/gotestsum-report.xml -- $(GOTEST_PKGS)

bench:
@go test $(TEST_VERBOSE_ARG) -run DONTRUNTESTS -bench $(BENCHTESTS) $(BENCHFULL_ARG) -benchtime=$(BENCHTIME) $(GOTEST_PKGS)

Expand Down

0 comments on commit 9687b8b

Please sign in to comment.