Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntSliceFieldIndex #64

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

lggomez
Copy link

@lggomez lggomez commented May 23, 2019

Counterpart of StringSliceFieldIndex, with int values

This PR also includes isolated tests on a new StringSliceFieldIndex indexer (since the previous integration test schema had it inside of a CompoundMultiIndex)

@lggomez
Copy link
Author

lggomez commented May 23, 2019

CI had an unrecoverable error, this shouldn't be related to the changes:

#!/bin/sh -eo pipefail
# No configuration was found in your project. Please refer to https://circleci.com/docs/2.0/ to get started with your configuration.
# 
# -------
# Warning: This configuration was auto-generated to show you the message above.
# Don't rerun this job. Rerunning will have no effect.
false

@jefferai
Copy link
Member

Please look at IntFieldIndex and UintFieldIndex, they accept any type/size of uint/int. This makes an assumption as to the value being 32-bit which is much less flexible and potentially unsafe.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants