Close conn on WriteResponse errors

See hashicorp/net-rpc-msgpackrpc#15 for details.
hashicorp · Feb 7, 2025 · 325cf76 · 325cf76
1 parent bc22f4e
commit 325cf76
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/codec/rpc.go b/codec/rpc.go
@@ -162,7 +162,13 @@ func (c *goRpcCodec) WriteRequest(r *rpc.Request, body interface{}) error {
 }
 
 func (c *goRpcCodec) WriteResponse(r *rpc.Response, body interface{}) error {
-	return c.write(r, body, true)
+	err := c.write(r, body, true)
+	if err != nil {
+		// If error occurred writing a response, close the underlying connection.
+		// See hashicorp/net-rpc-msgpackrpc#15
+		c.Close()
+	}
+	return err
 }
 
 func (c *goRpcCodec) ReadResponseHeader(r *rpc.Response) error {