Close conn on WriteResponse errors

See hashicorp/net-rpc-msgpackrpc#15 for details.
hashicorp · Feb 7, 2025 · 86f17c1 · 86f17c1
1 parent 07c54c2
commit 86f17c1
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/codec/rpc.go b/codec/rpc.go
@@ -169,7 +169,13 @@ func (c *goRpcCodec) WriteRequest(r *rpc.Request, body interface{}) error {
 }
 
 func (c *goRpcCodec) WriteResponse(r *rpc.Response, body interface{}) error {
-	return c.write(r, body)
+	err := c.write(r, body)
+	if err != nil {
+		// If error occurred writing a response, close the underlying connection.
+		// See hashicorp/net-rpc-msgpackrpc#15
+		c.Close()
+	}
+	return err
 }
 
 func (c *goRpcCodec) ReadResponseHeader(r *rpc.Response) error {