Remove old (unused) logic related to legacy expressions (#354)

* Remove Expr from attribute schema

* Remove Expr from semantic tokens

* Remove Expr from reference targets

* Remove Expr from reference origins

* Remove legacy expressions

* Remove Expr from references

* Remove Expr from label and attribute

decoder/attribute_candidates.go

@@ -18,14 +18,9 @@ import (
 func attributeSchemaToCandidate(ctx context.Context, name string, attr *schema.AttributeSchema, rng hcl.Range) lang.Candidate {
 	var snippet string
 	var triggerSuggest bool
-	if attr.Constraint != nil {
-		cData := attr.Constraint.EmptyCompletionData(ctx, 1, 0)
-		snippet = fmt.Sprintf("%s = %s", name, cData.Snippet)
-		triggerSuggest = cData.TriggerSuggest
-	} else {
-		snippet = snippetForAttribute(name, attr)
-		triggerSuggest = triggerSuggestForExprConstraints(attr.Expr)
-	}
+	cData := attr.Constraint.EmptyCompletionData(ctx, 1, 0)
+	snippet = fmt.Sprintf("%s = %s", name, cData.Snippet)
+	triggerSuggest = cData.TriggerSuggest
 
 	return lang.Candidate{
 		Label:        name,
@@ -55,12 +50,7 @@ func detailForAttribute(attr *schema.AttributeSchema) string {
 		details = append(details, "sensitive")
 	}
 
-	var friendlyName string
-	if attr.Constraint != nil {
-		friendlyName = attr.Constraint.FriendlyName()
-	} else {
-		friendlyName = attr.Expr.FriendlyName()
-	}
+	friendlyName := attr.Constraint.FriendlyName()
 
 	if friendlyName != "" {
 		details = append(details, friendlyName)
@@ -69,10 +59,6 @@ func detailForAttribute(attr *schema.AttributeSchema) string {
 	return strings.Join(details[:], ", ")
 }
 
-func snippetForAttribute(name string, attr *schema.AttributeSchema) string {
-	return fmt.Sprintf("%s = %s", name, snippetForExprContraints(1, attr.Expr))
-}
-
 func sortedObjectAttrNames(obj cty.Type) []string {
 	if !obj.IsObjectType() {
 		return []string{}