Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decoder: remove dead code #358

Merged
merged 1 commit into from
Jan 5, 2024
Merged

decoder: remove dead code #358

merged 1 commit into from
Jan 5, 2024

Conversation

giautm
Copy link
Contributor

@giautm giautm commented Jan 5, 2024

No description provided.

@giautm giautm requested a review from a team as a code owner January 5, 2024 16:55
radeksimko
radeksimko approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for the PR.

We should probably plug some "linter" into the pipeline which detects dead code but we haven't had the time/chance to investigate options and choose (and repeat that for every relevant repo the team manages yet).

@radeksimko radeksimko merged commit 6651691 into hashicorp:main Jan 5, 2024
5 checks passed
@giautm giautm deleted the g/dead-code branch January 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giautm @radeksimko