provisioner/powershell: Add wrapper script to default provisioner runs #9884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a wrapper script to the provisioner for improved error handling. The wrapper script is enabled by default, but will be disabled when using a custom ExecuteCommand or ElevatedExecuteCommand. The wrapper script will include the contents of any provided Inline commands or Scripts as part of its payload and run as a single script with environment variables loaded within the script. This changes the existing behavior of uploading any defined script(s) unmodified to the remote host.
nywilken
commented
Sep 3, 2020
| config Config | ||
| communicator packer.Communicator | ||
| generatedData map[string]interface{} | ||
| useWrappedCommmand bool |
There was a problem hiding this comment.
Old artifact that needs to be removed.
|
Closing this PR for now. Will revisit at a later time. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a wrapper script to the provisioner for improved error handling. The wrapper script is enabled by default, but will be disabled when using a custom ExecuteCommand or ElevatedExecuteCommand.
The wrapper script will include the contents of any provided Inline commands or Scripts as part of its payload and run as a single script with environment variables loaded within the script. This changes the existing behavior of uploading and running any defined script(s) directly to the remote host
Closes #4916, #9757, #9400, #9161
Todo