Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy MySQL 2020-01-01 #2823

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Legacy MySQL 2020-01-01 #2823

merged 1 commit into from
Jul 26, 2023

Conversation

mbfrahry
Copy link
Member

This PR adds legacy 2020-01-01 mysql to pandora. Not sure if this is the right way to do this but it's what we need to migrate mysql over to go-azure-sdk

API Specs for reference https://github.com/Azure/azure-rest-api-specs/tree/7c50841aadb4bfc241de3f09146e1f97ce3583b2/specification/mysql/resource-manager/Microsoft.DBforMySQL/legacy/stable/2020-01-01

This PR adds legacy 2020-01-01 mysql to pandora. Not sure if this is the right way to do this but it's what we need to migrate mysql over to go-azure-sdk

API Specs for reference https://github.com/Azure/azure-rest-api-specs/tree/7c50841aadb4bfc241de3f09146e1f97ce3583b2/specification/mysql/resource-manager/Microsoft.DBforMySQL/legacy/stable/2020-01-01
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we might also need the two older versions here, although would the newer API versions work?

 $ cd vendor/github.com/Azure/azure-sdk-for-go/services/mysql/mgmt/2020-01-01/mysql
 $ grep -h -R "APIVersion = " | sort | uniq
	const APIVersion = "2017-12-01"
	const APIVersion = "2018-06-01"
	const APIVersion = "2020-01-01"

@mbfrahry
Copy link
Member Author

I just poked through those apis and they only hold stuff that we aren't using so hopefully we don't need it

@mbfrahry mbfrahry merged commit 6073bc3 into main Jul 26, 2023
2 checks passed
@mbfrahry mbfrahry deleted the legacy-mysql-2020-01-01 branch July 26, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants