Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: add billing service to aws provider #41000

Merged
merged 14 commits into from
Jan 21, 2025
Merged

service: add billing service to aws provider #41000

merged 14 commits into from
Jan 21, 2025

Conversation

hjoshi123
Copy link
Contributor

Description

This PR involves regarding the new billing package that AWS introduced recently. For this, there are a bunch of data sources and resource(s) to be created. This PR is the first step of it to create a new service.

Relations

Relates #40677

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/billing#Client.CreateBillingView

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. github_actions Pull requests that update Github_actions code needs-triage Waiting for first response or review from a maintainer. labels Jan 19, 2025
@hjoshi123 hjoshi123 changed the title billing new service service: add billing service to aws provider Jan 19, 2025
@hjoshi123
Copy link
Contributor Author

@justinretzolk would love to get your opinion on this as I am confused. Should I put the endpoint configuration currently and remove the not_implemented attribute or do I put the endpoint config while I am working on the actual resources and data sources?

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 20, 2025
@ewbankkit ewbankkit force-pushed the f-aws_billing_view-newservice branch from 36b7b40 to 14a096f Compare January 20, 2025 21:08
ewbankkit
ewbankkit previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBillingServiceAccountDataSource_' PKG=billing
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/billing/... -v -count 1 -parallel 20  -run=TestAccBillingServiceAccountDataSource_ -timeout 360m -vet=off
2025/01/20 16:09:17 Initializing Terraform AWS Provider...
=== RUN   TestAccBillingServiceAccountDataSource_basic
=== PAUSE TestAccBillingServiceAccountDataSource_basic
=== CONT  TestAccBillingServiceAccountDataSource_basic
--- PASS: TestAccBillingServiceAccountDataSource_basic (7.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/billing	12.697s

@hjoshi123
Copy link
Contributor Author

@ewbankkit it would be nice if you could share your opinion for the billing service. What would be the endpoint_api_call for this service? I thought it would be https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_billing_ListBillingViews.html. But with the billing_service_account I am not sure anymore.

ewbankkit
ewbankkit approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@hjoshi123 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0afc39a into hashicorp:main Jan 21, 2025
54 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 21, 2025
@hjoshi123
Copy link
Contributor Author

@ewbankkit thank you for chipping in and resolving the issues quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust breathingdust is a code owner

@justinretzolk justinretzolk Awaiting requested review from justinretzolk justinretzolk is a code owner

Assignees
No one assigned
Labels
generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.85.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hjoshi123 @ewbankkit