Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource] aws_vpclattice_resource_configuration #41019

Merged
merged 36 commits into from
Jan 27, 2025

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jan 21, 2025

Description

New resource to configure VPC Lattice Resource Configurations

Relations

Relates #40384

References

Output from Acceptance Testing

% make testacc ACCTEST_PARALLELISM=5 TESTS=TestAccVPCLatticeResource PKG=vpclattice
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/vpclattice/... -v -count 1 -parallel 5 -run='TestAccVPCLatticeResource'  -timeout 360m -vet=off
2025/01/22 14:53:16 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCLatticeResourceConfiguration_tags
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_null
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_null
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyMap
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyMap
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_basic
=== PAUSE TestAccVPCLatticeResourceConfiguration_basic
=== RUN   TestAccVPCLatticeResourceConfiguration_update
=== PAUSE TestAccVPCLatticeResourceConfiguration_update
=== RUN   TestAccVPCLatticeResourceConfiguration_ipAddress
=== PAUSE TestAccVPCLatticeResourceConfiguration_ipAddress
=== RUN   TestAccVPCLatticeResourceConfiguration_parentChild
=== PAUSE TestAccVPCLatticeResourceConfiguration_parentChild
=== RUN   TestAccVPCLatticeResourceConfiguration_arnResource
=== PAUSE TestAccVPCLatticeResourceConfiguration_arnResource
=== RUN   TestAccVPCLatticeResourceConfiguration_disappears
=== PAUSE TestAccVPCLatticeResourceConfiguration_disappears
=== RUN   TestAccVPCLatticeResourceGateway_tags
=== PAUSE TestAccVPCLatticeResourceGateway_tags
=== RUN   TestAccVPCLatticeResourceGateway_tags_null
=== PAUSE TestAccVPCLatticeResourceGateway_tags_null
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyMap
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyMap
=== RUN   TestAccVPCLatticeResourceGateway_tags_AddOnUpdate
=== PAUSE TestAccVPCLatticeResourceGateway_tags_AddOnUpdate
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_basic
=== PAUSE TestAccVPCLatticeResourceGateway_basic
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== RUN   TestAccVPCLatticeResourceGateway_multipleSubnets
=== PAUSE TestAccVPCLatticeResourceGateway_multipleSubnets
=== RUN   TestAccVPCLatticeResourceGateway_update
=== PAUSE TestAccVPCLatticeResourceGateway_update
=== RUN   TestAccVPCLatticeResourceGateway_disappears
=== PAUSE TestAccVPCLatticeResourceGateway_disappears
=== RUN   TestAccVPCLatticeResourcePolicyDataSource_basic
=== PAUSE TestAccVPCLatticeResourcePolicyDataSource_basic
=== RUN   TestAccVPCLatticeResourcePolicy_basic
=== PAUSE TestAccVPCLatticeResourcePolicy_basic
=== RUN   TestAccVPCLatticeResourcePolicy_disappears
=== PAUSE TestAccVPCLatticeResourcePolicy_disappears
=== CONT  TestAccVPCLatticeResourceConfiguration_tags
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyMap
=== CONT  TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeIPv6
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyMap (48.66s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag (54.67s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeIPv6 (72.24s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate (75.09s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag (46.10s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag (46.93s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag (45.63s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCLatticeResourceConfiguration_tags (129.09s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag (46.33s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping (102.99s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly (68.00s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly (67.82s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag (47.87s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag (49.99s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag (47.41s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping (106.04s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly (70.67s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly (70.67s)
=== CONT  TestAccVPCLatticeResourcePolicyDataSource_basic
--- PASS: TestAccVPCLatticeResourcePolicyDataSource_basic (18.90s)
=== CONT  TestAccVPCLatticeResourcePolicy_disappears
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace (63.35s)
=== CONT  TestAccVPCLatticeResourcePolicy_basic
--- PASS: TestAccVPCLatticeResourcePolicy_disappears (19.47s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping (103.96s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourcePolicy_basic (21.81s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping (97.71s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate (68.09s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly (125.19s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate (71.57s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyMap
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add (86.13s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyMap (47.41s)
=== CONT  TestAccVPCLatticeResourceGateway_update
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace (67.10s)
=== CONT  TestAccVPCLatticeResourceGateway_disappears
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate (66.71s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly (133.06s)
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeDualstack
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add (91.95s)
=== CONT  TestAccVPCLatticeResourceGateway_basic
--- PASS: TestAccVPCLatticeResourceGateway_disappears (40.79s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_AddOnUpdate
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeDualstack (46.14s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceGateway_basic (43.74s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccVPCLatticeResourceGateway_update (87.20s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_null
--- PASS: TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag (80.71s)
=== CONT  TestAccVPCLatticeResourceConfiguration_update
--- PASS: TestAccVPCLatticeResourceGateway_tags_AddOnUpdate (63.48s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_null
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_null (46.78s)
=== CONT  TestAccVPCLatticeResourceGateway_tags
--- PASS: TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace (70.31s)
=== CONT  TestAccVPCLatticeResourceConfiguration_disappears
--- PASS: TestAccVPCLatticeResourceGateway_tags_null (44.34s)
=== CONT  TestAccVPCLatticeResourceConfiguration_arnResource
--- PASS: TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag (78.29s)
=== CONT  TestAccVPCLatticeResourceConfiguration_parentChild
--- PASS: TestAccVPCLatticeResourceConfiguration_update (69.26s)
=== CONT  TestAccVPCLatticeResourceConfiguration_ipAddress
--- PASS: TestAccVPCLatticeResourceConfiguration_disappears (43.13s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourceConfiguration_parentChild (48.79s)
=== CONT  TestAccVPCLatticeResourceGateway_multipleSubnets
--- PASS: TestAccVPCLatticeResourceConfiguration_ipAddress (71.76s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccVPCLatticeResourceGateway_tags (115.16s)
=== CONT  TestAccVPCLatticeResourceConfiguration_basic
--- PASS: TestAccVPCLatticeResourceGateway_multipleSubnets (45.20s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add (68.57s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourceConfiguration_basic (46.37s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag (85.04s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add (78.06s)
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag (90.45s)
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace (77.70s)
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate (55.95s)


--- PASS: TestAccVPCLatticeResourceConfiguration_arnResource (1439.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 2033.479s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jan 21, 2025
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 21, 2025
@drewtul drewtul marked this pull request as ready for review January 22, 2025 14:31
@drewtul drewtul requested a review from a team as a code owner January 22, 2025 14:31
@ewbankkit ewbankkit self-assigned this Jan 22, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 22, 2025
ewbankkit
ewbankkit previously approved these changes Jan 27, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeResourceConfiguration_' PKG=vpclattice ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeResourceConfiguration_ -timeout 360m -vet=off
2025/01/27 08:01:35 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCLatticeResourceConfiguration_tags
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_null
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_null
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyMap
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyMap
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccVPCLatticeResourceConfiguration_basic
=== PAUSE TestAccVPCLatticeResourceConfiguration_basic
=== RUN   TestAccVPCLatticeResourceConfiguration_update
=== PAUSE TestAccVPCLatticeResourceConfiguration_update
=== RUN   TestAccVPCLatticeResourceConfiguration_ipAddress
=== PAUSE TestAccVPCLatticeResourceConfiguration_ipAddress
=== RUN   TestAccVPCLatticeResourceConfiguration_parentChild
=== PAUSE TestAccVPCLatticeResourceConfiguration_parentChild
=== RUN   TestAccVPCLatticeResourceConfiguration_arnResource
=== PAUSE TestAccVPCLatticeResourceConfiguration_arnResource
=== RUN   TestAccVPCLatticeResourceConfiguration_disappears
=== PAUSE TestAccVPCLatticeResourceConfiguration_disappears
=== CONT  TestAccVPCLatticeResourceConfiguration_tags
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccVPCLatticeResourceConfiguration_basic
--- PASS: TestAccVPCLatticeResourceConfiguration_basic (37.03s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullOverlappingResourceTag (49.42s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyProviderOnlyTag (37.05s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCLatticeResourceConfiguration_tags (87.15s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_emptyResourceTag (37.88s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_providerOnly (94.55s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToResourceOnly (55.25s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_updateToProviderOnly (52.37s)
=== CONT  TestAccVPCLatticeResourceConfiguration_parentChild
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_overlapping (75.66s)
=== CONT  TestAccVPCLatticeResourceConfiguration_disappears
--- PASS: TestAccVPCLatticeResourceConfiguration_parentChild (37.81s)
=== CONT  TestAccVPCLatticeResourceConfiguration_arnResource
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nonOverlapping (74.16s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCLatticeResourceConfiguration_disappears (33.71s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnCreate (53.65s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Replace (50.76s)
=== CONT  TestAccVPCLatticeResourceConfiguration_ipAddress
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyTag_OnUpdate_Add (66.73s)
=== CONT  TestAccVPCLatticeResourceConfiguration_update
--- PASS: TestAccVPCLatticeResourceConfiguration_ipAddress (52.63s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_EmptyMap
--- PASS: TestAccVPCLatticeResourceConfiguration_update (54.39s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_EmptyMap (42.06s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_null
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_null (36.29s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_AddOnUpdate (53.17s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Replace (52.67s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_ResourceTag (62.18s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnCreate (39.97s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_IgnoreTags_Overlap_DefaultTag (65.64s)
=== CONT  TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_DefaultTags_nullNonOverlappingResourceTag (37.61s)
--- PASS: TestAccVPCLatticeResourceConfiguration_tags_ComputedTag_OnUpdate_Add (53.09s)
--- PASS: TestAccVPCLatticeResourceConfiguration_arnResource (1371.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	1591.200s
% make testacc TESTARGS='-run=TestAccVPCLatticeResourceGateway_' PKG=vpclattice ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/vpclattice/... -v -count 1 -parallel 3  -run=TestAccVPCLatticeResourceGateway_ -timeout 360m -vet=off
2025/01/27 09:45:31 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCLatticeResourceGateway_tags
=== PAUSE TestAccVPCLatticeResourceGateway_tags
=== RUN   TestAccVPCLatticeResourceGateway_tags_null
=== PAUSE TestAccVPCLatticeResourceGateway_tags_null
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyMap
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyMap
=== RUN   TestAccVPCLatticeResourceGateway_tags_AddOnUpdate
=== PAUSE TestAccVPCLatticeResourceGateway_tags_AddOnUpdate
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate
=== RUN   TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccVPCLatticeResourceGateway_basic
=== PAUSE TestAccVPCLatticeResourceGateway_basic
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeDualstack
=== RUN   TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== PAUSE TestAccVPCLatticeResourceGateway_addressTypeIPv6
=== RUN   TestAccVPCLatticeResourceGateway_multipleSubnets
=== PAUSE TestAccVPCLatticeResourceGateway_multipleSubnets
=== RUN   TestAccVPCLatticeResourceGateway_update
=== PAUSE TestAccVPCLatticeResourceGateway_update
=== RUN   TestAccVPCLatticeResourceGateway_disappears
=== PAUSE TestAccVPCLatticeResourceGateway_disappears
=== CONT  TestAccVPCLatticeResourceGateway_tags
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag
=== CONT  TestAccVPCLatticeResourceGateway_basic
--- PASS: TestAccVPCLatticeResourceGateway_basic (35.46s)
=== CONT  TestAccVPCLatticeResourceGateway_multipleSubnets
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullOverlappingResourceTag (41.53s)
=== CONT  TestAccVPCLatticeResourceGateway_disappears
--- PASS: TestAccVPCLatticeResourceGateway_multipleSubnets (35.76s)
=== CONT  TestAccVPCLatticeResourceGateway_update
--- PASS: TestAccVPCLatticeResourceGateway_disappears (31.31s)
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeIPv6
--- PASS: TestAccVPCLatticeResourceGateway_tags (84.17s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeIPv6 (35.97s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCLatticeResourceGateway_update (63.10s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyProviderOnlyTag (35.63s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_emptyResourceTag (34.75s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_providerOnly (89.60s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToResourceOnly (48.91s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_updateToProviderOnly (48.77s)
=== CONT  TestAccVPCLatticeResourceGateway_addressTypeDualstack
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_overlapping (71.93s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceGateway_addressTypeDualstack (34.44s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_nonOverlapping (71.79s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Replace (51.13s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_ResourceTag (58.25s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourceGateway_tags_IgnoreTags_Overlap_DefaultTag (57.56s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnCreate (38.35s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCLatticeResourceGateway_tags_DefaultTags_nullNonOverlappingResourceTag (34.11s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCLatticeResourceGateway_tags_ComputedTag_OnUpdate_Add (55.94s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnCreate (50.02s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_EmptyMap
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Replace (47.10s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_AddOnUpdate
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyMap (35.58s)
=== CONT  TestAccVPCLatticeResourceGateway_tags_null
--- PASS: TestAccVPCLatticeResourceGateway_tags_EmptyTag_OnUpdate_Add (63.86s)
--- PASS: TestAccVPCLatticeResourceGateway_tags_AddOnUpdate (47.16s)
--- PASS: TestAccVPCLatticeResourceGateway_tags_null (34.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	460.872s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ae93494 into hashicorp:main Jan 27, 2025
45 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 27, 2025
@drewtul drewtul deleted the f-vpclattice-resource-configuration branch January 27, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants