Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_codepipeline add 'commands' attribute to support 'Compute' action category #41032

Closed

Conversation

neruneruo
Copy link

aws_codepipeline add commands attribute to support Compute action category

Description

Add attribute: commands in action block

Relations

Closes #39743

References

https://aws.amazon.com/about-aws/whats-new/2024/10/aws-codepipeline-general-purpose-compute-action/
https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-Commands.html

Output from Acceptance Testing

% make testacc TESTS='TestAccCodePipeline_' PKG=codepipeline
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codepipeline/... -v -count 1 -parallel 10 -run='TestAccCodePipeline_'  -timeout 360m
=== RUN   TestAccCodePipeline_basic
=== PAUSE TestAccCodePipeline_basic
=== RUN   TestAccCodePipeline_disappears
=== PAUSE TestAccCodePipeline_disappears
=== RUN   TestAccCodePipeline_emptyStageArtifacts
=== PAUSE TestAccCodePipeline_emptyStageArtifacts
=== RUN   TestAccCodePipeline_deployWithServiceRole
=== PAUSE TestAccCodePipeline_deployWithServiceRole
=== RUN   TestAccCodePipeline_tags
=== PAUSE TestAccCodePipeline_tags
=== RUN   TestAccCodePipeline_MultiRegion_basic
=== PAUSE TestAccCodePipeline_MultiRegion_basic
=== RUN   TestAccCodePipeline_MultiRegion_update
=== PAUSE TestAccCodePipeline_MultiRegion_update
=== RUN   TestAccCodePipeline_MultiRegion_convertSingleRegion
=== PAUSE TestAccCodePipeline_MultiRegion_convertSingleRegion
=== RUN   TestAccCodePipeline_withNamespace
=== PAUSE TestAccCodePipeline_withNamespace
=== RUN   TestAccCodePipeline_withGitHubV1SourceAction
    codepipeline_test.go:479: Environment variable GITHUB_TOKEN is not set, skipping test
--- SKIP: TestAccCodePipeline_withGitHubV1SourceAction (0.00s)
=== RUN   TestAccCodePipeline_ecr
=== PAUSE TestAccCodePipeline_ecr
=== RUN   TestAccCodePipeline_pipelinetype
=== PAUSE TestAccCodePipeline_pipelinetype
=== CONT  TestAccCodePipeline_basic
=== CONT  TestAccCodePipeline_MultiRegion_update
=== CONT  TestAccCodePipeline_ecr
=== CONT  TestAccCodePipeline_withNamespace
=== CONT  TestAccCodePipeline_MultiRegion_convertSingleRegion
=== CONT  TestAccCodePipeline_pipelinetype
=== CONT  TestAccCodePipeline_deployWithServiceRole
=== CONT  TestAccCodePipeline_MultiRegion_basic
=== CONT  TestAccCodePipeline_emptyStageArtifacts
=== CONT  TestAccCodePipeline_tags
--- PASS: TestAccCodePipeline_deployWithServiceRole (81.13s)
=== CONT  TestAccCodePipeline_disappears
--- PASS: TestAccCodePipeline_withNamespace (100.27s)
--- PASS: TestAccCodePipeline_MultiRegion_basic (101.40s)
--- PASS: TestAccCodePipeline_ecr (104.91s)
--- PASS: TestAccCodePipeline_emptyStageArtifacts (106.13s)
--- PASS: TestAccCodePipeline_disappears (49.09s)
--- PASS: TestAccCodePipeline_MultiRegion_update (141.85s)
--- PASS: TestAccCodePipeline_basic (143.70s)
--- PASS: TestAccCodePipeline_tags (151.65s)
--- PASS: TestAccCodePipeline_pipelinetype (168.90s)
--- PASS: TestAccCodePipeline_MultiRegion_convertSingleRegion (170.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline       170.754s

@neruneruo neruneruo requested a review from a team as a code owner January 22, 2025 09:49
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/codepipeline Issues and PRs that pertain to the codepipeline service. needs-triage Waiting for first response or review from a maintainer. labels Jan 22, 2025
@neruneruo neruneruo closed this Jan 22, 2025
@neruneruo neruneruo deleted the f-aws_codepipeline_compute_action branch January 22, 2025 10:04
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jan 22, 2025
@neruneruo
Copy link
Author

I created a pull request without updating the base branch, so I had to run the process again and reissue the pull request.

See #41034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: CodePipeline Compute/Commands action support
1 participant