Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aws_glue_security_configuration resource to support encrypting… #41414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vaquarkhan
Copy link

@vaquarkhan vaquarkhan commented Feb 15, 2025

… Glue Data Quality

Description

Relations

Closes #39821

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@vaquarkhan vaquarkhan requested a review from a team as a code owner February 15, 2025 22:39
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @vaquarkhan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@vaquarkhan
Copy link
Author

Please let me know next step

@vaquarkhan
Copy link
Author

#39821

@vaquarkhan
Copy link
Author

Hi Team , Can you please finish pending review.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 19, 2025
@justinretzolk
Copy link
Member

Hey @vaquarkhan 👋 Thank you very much for the contribution, and for checking in here! We base our prioritization on the count of 👍 reactions and a few other considerations. For more information, please see our prioritization guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: The aws_glue_security_configuration resource should support encrypting Glue Data Quality .
2 participants