Pass ephemeral variables to terraform apply #35903
Conversation
DanielMSchmidt
force-pushed
the
pass-ephemeral-variables-to-terraform-apply
branch
from
3b589fa
to
0bcd433
Compare
DanielMSchmidt
force-pushed
the
pass-ephemeral-variables-to-terraform-apply
branch
from
92c559a
to
3207836
Compare
radeksimko
added
the
1.10-backport
| Subject: rng, | ||
| }) | ||
| } else { | ||
| if v.Value.Equals(val) == cty.False { |
There was a problem hiding this comment.
cty.Values can't be directly compared (which is why you're using Equals). cty.Value has True() and False() methods for boolean operations.
There was a problem hiding this comment.
Note this probably works fine here due to the context so we don't ned to deal with nulls, unknowns, marks, etc. it's just that comparing a boolean in a boolean expression just looks so wrong ;)
| } | ||
| }, | ||
|
|
||
| // "passing ephemeral variable through interactive prompts": func(t *testing.T, c *ApplyCommand, statePath, planPath string, done func(*testing.T) *terminal.TestOutput) { |
There was a problem hiding this comment.
Is this something we intend to support?
There was a problem hiding this comment.
I think we do, I was planning on doing it in a separate PR though.
There was a problem hiding this comment.
hmm, I just tried the interactive prompt workflow, which is broken by this. Is there an easy way to disable interactive prompts in plan for now? The most common case for interactive prompts is someone simply running a combined plan+apply with terraform apply, which fails with No value for required variable.
This PR improves how we can pass values to ephemeral variables in the apply command, now CLI flags, environment variables, and vars files are supported. We will deal with interactive inputs in a separate PR to keep this one smaller.
Jira: TF-21848
Target Release
1.10.x
Draft CHANGELOG entry
ENHANCEMENTS