Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command/views: Attempt to fix flaky JSON hook test #35940

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

radeksimko
Copy link
Member

This is in reaction to a failure indicated in the CI:
https://github.com/hashicorp/terraform/actions/runs/11628307687/job/32383225309#step:6:91

Again - not ideal to use time.Sleep in general but the fix of the other test appears to have addressed the flakiness for now in #35927

@radeksimko radeksimko requested a review from a team November 1, 2024 15:36
@radeksimko radeksimko added the 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 1, 2024
@radeksimko radeksimko merged commit 8176657 into main Nov 4, 2024
6 checks passed
@radeksimko radeksimko deleted the radek/t-fix-flaky-ui-hook-test-json branch November 4, 2024 16:49
Copy link

github-actions bot commented Nov 4, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants