Deprecation Warning For Variables #36079
Conversation
DanielMSchmidt
force-pushed
the
input-deprecation
branch
from
adf67ff to
807ce06
Compare
| @@ -309,6 +309,15 @@ func (n *nodeModuleVariable) evalModuleVariable(ctx EvalContext, validateOnly bo | |||
| finalVal, moreDiags := prepareFinalInputVariableValue(n.Addr, rawVal, n.Config) | |||
| diags = diags.Append(moreDiags) | |||
|
|
|||
| if n.Config.DeprecatedSet && givenVal.IsWhollyKnown() && !givenVal.IsNull() && validateOnly { | |||
There was a problem hiding this comment.
If validateOnly is true, then givenVal may likely be unknown (unless maybe it's a static literal in the config). Validation is done with as many values unknown as possible since it should work for all possible input values, and to get the most complete evaluation possible of all branches in the configuration
If you look above however (L295), is appears that cty.NilVal is used here to represent an entirely unset input variable (due to the legacy ability to assign null as a value to override module inputs), so simple direct comparison to that should suffice here.
| @@ -92,6 +92,15 @@ func (n *NodeRootVariable) Execute(ctx EvalContext, op walkOperation) tfdiags.Di | |||
| } | |||
| } | |||
|
|
|||
| if n.Config.DeprecatedSet && givenVal.Value.IsWhollyKnown() && !givenVal.Value.IsNull() && op == walkPlan { | |||
There was a problem hiding this comment.
Similarly here, you should be able to determine if the variable is set by it being non-null. It's unfortunate that we have to wait until plan however.
Companion PR to #36016, should give us a warning for deprecated variables both when used on the root module and on child modules. With child modules it shows the input in the module call in the context, with root modules it shows the deprecation attribute of the variable in the context.
Fixes #18381
Target Release
1.11.x
Draft CHANGELOG entry
NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS